feat: watch public files that are imported by JavaScript #9770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
commented
Oct 20, 2022
| @@ -137,7 +137,7 @@ export function assetPlugin(config: ResolvedConfig): Plugin { | |||
| // will fail to resolve in the main resolver. handle them here. | |||
| const publicFile = checkPublicFile(id, config) | |||
| if (publicFile) { | |||
| return id | |||
| return { id: publicFile, meta: { publicUrl: id } } | |||
There was a problem hiding this comment.
So basically, the full file path is returned as the resolved ID and the original module URL is cached in meta.publicUrl for the assetPlugin to use.
There was a problem hiding this comment.
Could we call this.addWatchFile(publicFile) instead? Or maybe it's better to always return the absolute path, but I'm not sure any side effects with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of how
resolveIdin the assetPlugin returns the virtual ID as-is, it's hard for me to associate file changes with aModuleNode(the module node is addressed by the virtual ID instead of the absolute file path). This means public files imported in SSR won't trigger a hot reload.To fix this, I'm returning
{ id: publicFile, meta: { publicUrl: id } }from the resolveId hook in question. Unfortunately, returningmetafrom resolveId is not supported by Vite until #7477 or similar is merged, so this PR is blocked.What is the purpose of this pull request?